-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idl: Limit account size to 60kb, allow closing idl accounts #2329
Conversation
@microwavedcola1 is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
This looks nice, thanks for adding. @microwavedcola1 I don't know if you would mind adding a typescript test demonstrating the new close functionality to the existing set of IDL tests. https://github.com/coral-xyz/anchor/blob/master/tests/anchor-cli-idl/tests/idl.ts Also as with the other PRs
Thanks for all the great PRs! They all look like very nice additions to anchor, looking forward to merging. |
I played around with adding accounts larger than 10kb (by adding a realloc / resize account function) and it seems like adding bytes to write buffer causes a memory issue before it can even reach account sizes above 10kb. So unless someone wants to switch over all the old IDL code to using zero copy accounts, this is probably as big as the account can be for now. Not to mention, one issue with updating the IDL code to newer account types is that account types like Anyway, I just need to
And then it's ready to merge i think |
5fcd3f2
to
111e6cc
Compare
Weird compile error happening with some programs but not others. It's possible that it's linked to the use of
edit: Mostly sure this is due to no including fully qualified paths for |
Originally by @microwavedcola1