Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: allow the cfg attribute above the instructions #2339

Merged
merged 9 commits into from
Sep 16, 2024
Merged

lang: allow the cfg attribute above the instructions #2339

merged 9 commits into from
Sep 16, 2024

Conversation

Aursen
Copy link
Contributor

@Aursen Aursen commented Dec 23, 2022 •
edited
Loading

Closes #2257

The PR #2011 will solve the issue about the idl

@vercel
Copy link

vercel bot commented Dec 23, 2022

@Aursen is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Aursen Aursen marked this pull request as ready for review December 24, 2022 14:43
@Henry-E Henry-E added the blocked label Jan 3, 2023
@Henry-E
Copy link
Contributor

Henry-E commented Jan 3, 2023 •
edited
Loading

Assuming this PR is essentially blocked until #2011 is merged because of the issues around generating the IDL correctly.

@mina86
Copy link
Contributor

mina86 commented Nov 28, 2023

@Henry-E, now that #2011 is merged, can we have this merged?

acheroncrypto
acheroncrypto reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but one issue is that this only works with idl-build feature. Still, we should be able to get this in before the next release.

@acheroncrypto acheroncrypto mentioned this pull request May 4, 2024
Closed
@skrrb skrrb mentioned this pull request May 12, 2024
Open
@acheroncrypto acheroncrypto mentioned this pull request Sep 13, 2024
Closed
acheroncrypto
acheroncrypto requested changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning back to this after #3247. I think this looks great, but there are conflicts — are you able to fix them?

@Aursen
Copy link
Contributor Author

Aursen commented Sep 14, 2024

Returning back to this after #3247. I think this looks great, but there are conflicts — are you able to fix them?

Let me do it this weekend

@Aursen Aursen marked this pull request as draft September 15, 2024 20:48
@Aursen Aursen marked this pull request as ready for review September 15, 2024 21:38
acheroncrypto
acheroncrypto approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the ~2 year delay!

@acheroncrypto acheroncrypto merged commit e25918c into coral-xyz:master Sep 16, 2024
50 of 51 checks passed
@Aursen Aursen deleted the cfg branch September 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mina86 mina86 mina86 left review comments

@Henry-E Henry-E Henry-E left review comments

@acheroncrypto acheroncrypto acheroncrypto approved these changes

Assignees
No one assigned
Labels
feature lang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anchor #[program] macro appears to ignore cargo feature flags
4 participants
@Aursen @Henry-E @mina86 @acheroncrypto