Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syn: Fix IDL named enum variant field being snake_case #2633

Conversation

acheroncrypto
Copy link
Collaborator

Problem

Named enum variant fields are in snake_case as opposed to every other field being in camelCase in the IDL.

This has been addressed in the IDL build implementation(#2011) but the issue still persists with the parse method.

Summary of Changes

  • Convert the named enum variant fields to camelCase
  • Add a test case that uses an enum variant named field with multiple words(in snake_case)

It would be great if we could get rid of the case conversion in IDL but that would also have its own downsides(breaking change).

Closes #1443.

@vercel
Copy link

vercel bot commented Sep 21, 2023

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added bug Something isn't working idl related to the IDL, either program or client side labels Sep 21, 2023
@acheroncrypto acheroncrypto merged commit 3c6fc2b into coral-xyz:master Sep 21, 2023
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working idl related to the IDL, either program or client side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDL named enum fields are snake_case instead of camelCase
1 participant