Add NO_COLOR env var to coralogix-aws-shipper #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracing library that coralogix-aws-shipper supports NO_COLOR, which avoids sending ansi control characters to cloudwatch logs. * [tracing library pr](tokio-rs/tracing#2647) * [NO_COLOR](https://no-color.org/)
|
Hi @m-wynn I apologize for the late response, can you maybe share how you got these logs so I could try to duplicate the issue? I didn't see that the coralogix-aws-shipper is sending these logs to the log group that it creates, so I may be missing something. |
|
Looks like this was fixed in the rust code instead. coralogix/coralogix-aws-shipper@8119257#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tracing library that coralogix-aws-shipper supports NO_COLOR, which avoids sending ansi control characters to cloudwatch logs.
Before:
�[2m2024-05-08T18:15:41.991174Z�[0m �[33m WARN�[0m �[2mcoralogix_aws_shipper::process�[0m�[2m:�[0m Non Cloudtrail Log Ingested - Skipping -After:
2024-05-08T18:15:41.991174Z WARN coralogix_aws_shipper::process: Non Cloudtrail Log Ingested - Skipping -tracing library pr
NO_COLOR
How Has This Been Tested?
You can set
NO_COLORto1in your lambda and see that the control characters are no longer present in cloudwatch logs.Checklist: