Update ID lists to be empty

[gregops312]

When using modules/cloudwatch-logs the module "lambda" could have constant churn because of the possible introduction of "" in the list of vpc_subnet_ids and vpc_security_group_ids

Description

When using modules/cloudwatch-logs the module "lambda" could have constant churn because of the possible introduction of "" in the list of vpc_subnet_ids and vpc_security_group_ids

How Has This Been Tested?

I used my branch and ran against the churning issue. Screenshots have been added to PR as well.

Before

After

Checklist:

• I have updated the relevant example in the examples directory for the module.
• I have updated the relevant test file for the module.
• This change does not affect module (e.g. it's readme file change)
  • This isn't a readme change, but it should have no negative effects that I can fathom.

[royfur]

Hi @gregops312

Please note that cloudwatch-logs module is deprecated and you should use the coralogix-aws-shipper instead

[gregops312]

Hi @gregops312

Please note that cloudwatch-logs module is deprecated and you should use the coralogix-aws-shipper instead

Oh that's good to know. We can work on moving to that soon. So what is the process in getting this PR reviewed and available. Since it still exists I see no reason why it couldn't or shouldn't per say be maintained if people put forth the effort until it is entirely removed.

[royfur]

The reason it is not removed yet is since we didnt want to break customers environment in case they dont use specific version
The deprecation of this module was on May 1st and it is not maintained anymore

one of the reason that it is deprecated is that the lambda node version is not supported anymore in AWS and thats why we moved

[gregops312]

The reason it is not removed yet is since we didnt want to break customers environment in case they dont use specific version The deprecation of this module was on May 1st and it is not maintained anymore

one of the reason that it is deprecated is that the lambda node version is not supported anymore in AWS and thats why we moved

It makes sense why it hasn't been removed.

I would like to know what the path forward is on this PR, I see no reason why deprecated changes can't be made to make things better until it is removed. And you yourself made the point that is hasn't been removed because it is in use by customers, like myself, who would like to be able to use it and make it work for me, until at which point I can switch to the new implementation.

[guyrenny]

Looks good

[gregops312]

Looks good

Looks good

Thank you very much! We'll definitely put some work on our backlog for changing to the new module!