This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
comment listener/readability prototype #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #mongo_host = os.environ['MONGODB_HOST'] | ||
| except Exception as err: | ||
| print("ERROR: Environment variable not found. " + err, file=sys.stderr) | ||
| exit() |
There was a problem hiding this comment.
you should send a non-zero exit, like exit(1), that way if you include this as part of some other tooling, they can infer something wrong happened by the exit code.
|
Great. Can we add some tests to this? |
|
I'm going to close this in favor of whatever happens with coral-stats branch. Will add tests there :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test of scale etc for doing readability scores. Integration points are rabbitmq (publisher is currently Pillar) and scores go to stdout. Stdout would need to be replaced.
This also gives us another couple of data points for statsd.