Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1238] Duplicate User Race #3068

Merged
merged 3 commits into from Aug 4, 2020
Merged

[CORL-1238] Duplicate User Race #3068

merged 3 commits into from Aug 4, 2020

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Aug 3, 2020

What does this PR do?

As reported in #3061, sometimes SSO authentications can cause a duplicate user error to be thrown when multiple requests are sent at the same time. This introduces a single retry if the operation fails due to a duplicate user error.

What changes to the GraphQL/Database Schema does this PR introduce?

None.

How do I test this PR?

This is pretty difficult to test in action because it involves a database race to occur. This change was motivated from the documentation provided in #3061 (comment) (seen here: https://docs.mongodb.com/manual/reference/method/db.collection.findAndModify/#upsert-and-unique-index)

@wyattjoh wyattjoh added the bug label Aug 3, 2020
@wyattjoh wyattjoh added this to the v6.4.0 milestone Aug 3, 2020
@wyattjoh wyattjoh requested a review from tessalt August 3, 2020 19:01
@wyattjoh wyattjoh added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 4, 2020
@kodiakhq kodiakhq bot merged commit 8aac2d3 into master Aug 4, 2020
@kodiakhq kodiakhq bot deleted the bugfix/CORL-1238 branch August 4, 2020 18:09
@kgardnr kgardnr modified the milestones: v6.4.0, v6.3.2 Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants