-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update README #164
chore: Update README #164
Conversation
2a1c618
to
d5253fb
Compare
This commit updates the README to include the findings in corazawaf#137, because it is useful to have this information directly in the README rather than having to search for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The next obvious step will be (in a followup PR) to add this example as part of the github action build process, so we can test everything works properly 😄
Great. Do you mean adding it to e2e tests? |
🤔 It was more about checking that the example files are sane and won't break anything if used. |
Note: tests are failing because of #165, this branch needs to be rebased once that PR is merged |
Quality Gate passedIssues Measures |
This commit updates the README to include the findings in #137, because it is useful to have this information directly in the README rather than having to search for it.