Add support for Clone Field #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrossi
reviewed
Mar 22, 2017
| @@ -115,6 +115,12 @@ public function fetchFieldKey($fieldName) | |||
| */ | |||
| public function fetchFieldType($fieldKey) | |||
| { | |||
| // Check if this a clone field. If it is, return the field type of its clone. | |||
| $fieldKeyIds = explode('_', $fieldKey); | |||
| if (count($fieldKeyIds) == 4) { | |||
There was a problem hiding this comment.
Hi @njbarrett how are you considering 4 tokens here? If I have a field called first_name? Does it still work?
There was a problem hiding this comment.
well the field name wont matter here, as this function gets the field type using the keys which are always field_{somehexvalue} e.g field_349efabab23 so the execution path is quite predictable
There was a problem hiding this comment.
Actually you might be right, i forgot you can name the field keys too. May need to come up with another way.
There was a problem hiding this comment.
I think a regex is better here. Something like /field_([A-Za-z0-9_-]+)_foo_bar/. Whenever you can please take a look on this. Don't worry about that. Thanks for contributing. JG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the clone field type (fairly new acf type that clones another field) then you get an error:
Call to a member function get() on null
ACF stores clone fields as {fieldkey}_{clonedfieldkey} e.g
field_58d217c0bbeef_field_58cb8919c2607so we can extract the parent's field type instead and everything works as expected.