Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Examples Independent Projects #53

Closed
wants to merge 4 commits into from

Conversation

opticyclic
Copy link
Contributor

As per #46 this makes the examples independent projects that can be copied and used as a base for new work in a similar way to the https://github.com/corda/samples projects.

@roger-that-dev
Copy link

roger-that-dev commented Sep 21, 2019

Thanks for doing this - We'll review and merge this in on Monday 👍

@roastario
Copy link
Contributor

I'm not sure this is a good idea for all of the samples.

They test important functionality. I think we should do this only after we've added more tests to the core modules.

@roger-that-dev
Copy link

@roastario Hmm that is a good point - yes we are kind of relying on them for integration tests at the moment. @opticyclic do you mind if we hold fire on this for the time being? Cheers

@sudharsananandakumar
Copy link

Hi, am not able to run the deployNodes task on this independent examples. Attached is the error log. can you please advise?
The OS is windows server 2012
node-info-gen.log

@opticyclic
Copy link
Contributor Author

Hi, am not able to run the deployNodes task on this independent examples. Attached is the error log. can you please advise?
The OS is windows server 2012
node-info-gen.log

It is unlikely that you are running this on Windows Server since the error says:

java.lang.UnsatisfiedLinkError: sun.tools.attach.LinuxVirtualMachine.isLinuxThreads

Which implies a Linux OS.

However, this error often means that you don't have the tools.jar in your JDK classpath.

@sudharsananandakumar
Copy link

Hi, am not able to run the deployNodes task on this independent examples. Attached is the error log. can you please advise?
The OS is windows server 2012
node-info-gen.log

It is unlikely that you are running this on Windows Server since the error says:

java.lang.UnsatisfiedLinkError: sun.tools.attach.LinuxVirtualMachine.isLinuxThreads

Which implies a Linux OS.

However, this error often means that you don't have the tools.jar in your JDK classpath.

Hi, Thanks for your reply... Am in fact running it on a windows machine and am able to run other cordApps that I have created without any problem

@opticyclic
Copy link
Contributor Author

This is a pull request not a support forum.

@opticyclic
Copy link
Contributor Author

Closing as merges from other PRs meant the code could no longer be simply merged and had to be re-done.

See #74

@opticyclic opticyclic closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants