feat/theme-breakpoint #1213
Merged
feat/theme-breakpoint #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulcanellee
requested review from
reme3d2y,
churicheva-v and
SiebenSieben
as code owners
🦋 Changeset detectedLatest commit: bc5ca30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 77 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 10922737144Details
💛 - Coveralls |
|
Собрана новая демка. |
|
Собрана новая демка. |
|
Собрана новая демка. |
|
Собрана новая демка. |
|
|
||
| ## Глобальные брейкпоинты | ||
| Как уже было сказано, по умолчанию брейкпоинты в компонентах установлены на `1024px`. | ||
| Это значение можно переопределить глобально. Для этого необходимо подключить в корневой CSS файл необходимый брейкпоинт. |
There was a problem hiding this comment.
Если это нужно в теме corp, то может сразу в неё подключить?
There was a problem hiding this comment.
Думаю, пусть сами поправят, во избежание непредвиденных поломок.
|
Собрана новая демка. |
|
Собрана новая демка. |
|
Собрана новая демка. |
hextion
approved these changes
Jun 28, 2024
|
Потестил доработку у нас в сторибуке, все ок, если не выпиливать css переменные при сборке. Проблема будет в продуктовых командах которые выпиливают переменные, у них просто не будет работать |
…heme_breakpoint # Conflicts: # packages/button/src/Component.responsive.tsx # packages/shared/src/index.ts
|
Собрана новая демка. |
|
Собрана новая демка. |
|
Собрана новая демка. |
…heme_breakpoint # Conflicts: # packages/calendar/src/Component.responsive.tsx # packages/checkbox-group/src/Component.responsive.tsx # packages/code-input/src/Component.responsive.tsx # packages/confirmation/src/component.responsive.tsx # packages/custom-picker-button/src/Component.responsive.tsx # packages/filter-tag/src/Component.responsive.tsx # packages/pattern-lock/src/Component.responsive.tsx # packages/plate/src/Component.responsive.tsx # packages/radio-group/src/Component.responsive.tsx # packages/tag/src/Component.responsive.tsx # packages/toast-plate/src/Component.responsive.tsx # packages/toast/src/Component.responsive.tsx
|
Собрана новая демка. |
|
Собрана новая демка. |
…heme_breakpoint # Conflicts: # packages/amount-input/package.json # packages/calendar-input/package.json # packages/checkbox-group/package.json # packages/code-input/package.json # packages/custom-picker-button/package.json # packages/date-range-input/package.json # packages/date-time-input/package.json # packages/filter-tag/package.json # packages/picker-button/package.json # packages/radio-group/package.json # packages/select-with-tags/package.json # packages/tag/package.json # packages/toast-plate/package.json # packages/toast/package.json # packages/tooltip/package.json
|
Собрана новая демка. |
|
Потестил доработку через js все ок |
NikitaRodyukov
approved these changes
Sep 16, 2024
…heme_breakpoint # Conflicts: # packages/amount-input/package.json
|
Собрана новая демка. |
SiebenSieben
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
Добавил возможность глобального переопределения breakpoint компонентов
Бета
https://www.npmjs.com/package/@alfalab/core-components/v/47.3.0-beta.0