Fix/restore theme vars #1282
Merged
Fix/restore theme vars #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab6a548.
fulcanellee
requested review from
reme3d2y,
churicheva-v,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: a50472a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SiebenSieben
approved these changes
Jul 4, 2024
churicheva-v
approved these changes
Jul 4, 2024
Pull Request Test Coverage Report for Build 9790080337Details
💛 - Coveralls |
hextion
requested changes
Jul 4, 2024
| ignore: ignorePattern, | ||
| }) | ||
| .filter(createColorsByPaletteFilter()) | ||
| .filter((varFile) => varFile.includes('index.css') === false) |
There was a problem hiding this comment.
!varFile.includes('index.css') ?
| * 'postcss-custom-properties' - заменяет переменные значениями, что без дублирования импортов переменных будет приводить к потере значений | ||
| */ | ||
| const getImports = () => { | ||
| if (cssFile.includes('dark.css')) return []; |
There was a problem hiding this comment.
условие в withImports перенести бы, а то не очень явно, что обработки никакой нет для файла
| @@ -20,15 +20,6 @@ | |||
| - Минорное<br />`codemod` | |||
|
|
|||
|
|
|||
| ### [#1191](https://github.com/core-ds/core-components/pull/1191) | |||
There was a problem hiding this comment.
стоит оставить и добавить комментарий, что текущий PR это откат
hextion
approved these changes
Jul 4, 2024
Pull Request Test Coverage Report for Build 9790196496Details
💛 - Coveralls |
reme3d2y
approved these changes
Jul 4, 2024
Pull Request Test Coverage Report for Build 9790374911Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9790460116Details
💛 - Coveralls |
|
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.