Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navigation-bar): add forwardRef to component #1285

Closed
wants to merge 2 commits into from

Conversation

evgencode
Copy link
Contributor

Обернуть компонент NavigationBar в forwardRef

Опишите проблему

Нужна необходимость зацепиться за рутовую дивку компонента извне

Ожидаемое поведение

Должно прокидывать рефу наверх

Чек лист

  • Тесты
  • Документация

Внешний вид

Ожидаемый Фактический
** Ожидаемый ** ** Фактический **

Тестовый стенд

Десктоп (если данных нет оставте блок пустым):

  • OS: MacOS
  • Browser: Safari
  • Version: 10

Смартфон (если данных нет оставте блок пустым):

  • Device: iPhone 6
  • OS: iOS 10
  • Browser: Chrome
  • Version: 65

Дополнительная информация

Дополнительная информация

surround the component by forwardRef
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 5ef18ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-navigation-bar Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9870524942

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.653%

Totals Coverage Status
Change from base Build 9809301667: 0.0%
Covered Lines: 10074
Relevant Lines: 11075

💛 - Coveralls

@evgencode
Copy link
Contributor Author

Создан новый не из-под форка: #1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants