Allow to skip ConfigMap creation #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where zones are different but plugins are. In order to avoid duplication of whole zone block configuration, allow to disable config map creation and let it to be managable externally, where it is possible to keep plugins configuration same, but change zone definition only. Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
Signed-off-by: Jack Lindamood <jack@x.ai>
|
Hi @hagaibarel , this is the rebased PR |
hagaibarel
requested changes
May 28, 2024
|
@cep21 I think the last commit wasn't properly signed-off, please fix |
Signed-off-by: Jack Lindamood <jack@x.ai>
Fixed! |
hagaibarel
approved these changes
May 30, 2024
|
@cep21 great job, thanks for working on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
A requested rebase and merge from PR #41
Which issues (if any) are related?
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.