Fix custom event arguments #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tol1
force-pushed
the
fix-custom-event-args
branch
from
82b6f36
to
332738d
Compare
|
+1 waiting for this fix |
|
Is there any temporary fix until v0.11.2 comes out? Thanks! |
|
👍 This might be at least merged to a dev branch |
|
@Tol1 Any chance you could rebase again and update this PR? We're working towards a release soon, and it'd be good to include this fix. |
|
I'll rebase as soon as I have time |
Tol1
force-pushed
the
fix-custom-event-args
branch
from
332738d
to
e7fb159
Compare
|
Rebased, this should be mergeable now |
|
👍 Thanks @Tol1 . @CoreSystemDevelopment Could you give this a review as well? |
|
Also probably fixes #89 |
This was referenced Nov 10, 2016
|
Hi @aaaa0441, I think you put your comment on the wrong issue. This is the crejavascript fork that's being maintained. :-) |
|
oops, my bad. Thanks, @jlbooker, for keeping this project maintained! =) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmerged pull request from author of upstream twitter/typeahead.js#1207
Rebased original to be mergeable
Closes #63 and #58