Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

providers/hetzner: private ipv4 addresses in attributes #1094

Merged
merged 1 commit into from
Jul 23, 2024
Merged

providers/hetzner: private ipv4 addresses in attributes #1094

merged 1 commit into from
Jul 23, 2024

Conversation

apricote
Copy link
Contributor

Adds new attributes AFTERBURN_HETZNER_PRIVATE_IPV4_* set to the servers IPv4 addresses in private networks.

This is useful for e.g. discovery of etcd members that should communicate over the private network.

I do not really know Rust well, so please take a closer look at the code :)

@apricote apricote mentioned this pull request Jul 21, 2024
Merged
@apricote
providers/hetzner: private ipv4 addresses in attributes
0de46d6 
Adds new attributes `AFTERBURN_HETZNER_PRIVATE_IPV4_*` set to the
servers IPv4 addresses in private networks.

This is useful for e.g. discovery of etcd members that should
communicate over the private network.

Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
@tormath1 tormath1 mentioned this pull request Jul 22, 2024
Merged
@tormath1
Copy link
Contributor

For information, it has been successfully tried on Flatcar:

$ cat /run/metadata/flatcar
COREOS_HETZNER_PUBLIC_IPV4=37.27.86.69
COREOS_HETZNER_INSTANCE_ID=50773413
COREOS_HETZNER_REGION=eu-central
COREOS_HETZNER_AVAILABILITY_ZONE=hel1-dc2
COREOS_HETZNER_PRIVATE_IPV4_0=10.0.0.2
COREOS_HETZNER_PRIVATE_IPV4_1=10.1.0.2
COREOS_HETZNER_HOSTNAME=snapshot-177311839-ubuntu-4gb-hel1-1

(flatcar/scripts#2141)

travier
travier approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I have not tested it however.

@travier
Copy link
Member

travier commented Jul 23, 2024

Thanks @tormath1 !

@travier travier merged commit 5733dc0 into coreos:main Jul 23, 2024
9 checks passed
@travier
Copy link
Member

travier commented Jul 23, 2024

and thanks @apricote for the PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apricote @tormath1 @travier