provider: add boot check-in on azure and packet #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
changed the title
This adds a phone-home feature via the `--check-in` flag, in order to support reporting back readiness state to the hosting infrastructure. Initial implementation supports azure and packet.
There's no need for GET requests to have a Content-Type header since it's only useful as a way to interpret the message body, which by definition GET requests do not have.
A POST request doesn't have to have a body. Make the `body` argument an `Option` to reflect that.
First, we were incorrectly building the `/events` URL. But second, POSTing a "succeeded" message is not a substitute for phoning home; we still need to do that. In which case, there's no need to POST to `/events` also. So let's just simplify things and do a POST only to `/phone-home`, just like `packet-phone-home.service`.
The MIME type for JSON is `application/json`, not `text/json`. Packet was choking on this as a result.
|
OK, this is now tested working on both Packet and Azure. ✔️ |
lucab
reviewed
Mar 5, 2019
|
@jlebon LGTM, thanks for catching my mistakes! Any last minute thing before I merge this? |
|
Nope, this is good to go! |
lucab
approved these changes
Mar 5, 2019
|
@lucab This is significant enough to warrant a new release. Can you guys create one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a respin of #130. So far it's mostly #130 rebased on top of #145 + minor fixes squashed in. A basic test in Azure works, though I'd like to test it some more. No testing done on Packet yet.