providers/hetzner: add support for Hetzner Cloud #996
Conversation
Signed-off-by: Manuel Hutter <manuel@hutter.io>
There was a problem hiding this comment.
Hetzner Cloud employee here 👋 This looks good from a metadata service usage perspective.
Does the provider also need to implement the networks related methods from MetadataProvider (e.g. networks, virtual_network_devices, rd_network_kargs) or are these optional?
|
As I understand them they are optional, and configuration via DHCP "just works" in my tests, however I could imagine that this could be implemented in the future. For example, it would be interesting to have somewhat stable interface identifiers (if that is even doable) for servers that have both public and internal IP's. |
|
@mhutter Firstly thank you so much for working on this. I wanted to update you and let you know I will be taking a look at this PR in the coming days. I will try and get back to you with any questions soon. Thank you again! |
This commit implements initial support for Hetzner Cloud. Supported features: - Attributes - Hostname - SSH Keys "hetzner" was choosen as the platform identifier, as proposed in [1]. [1]: coreos/fedora-coreos-tracker#1324 (comment) Resolves: #125 Relates: coreos/fedora-coreos-tracker#1324 Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter
changed the title
This commit implements initial support for Hetzner Cloud.
Supported features:
"hetzner" was choosen as the platform identifier, as proposed in coreos/fedora-coreos-tracker#1324 (comment).
Note that I decided to open a new PR over #125, since
but I don't have any hard feelings regarding merging this into #125 either.
Depending on how this goes I can work on the Ignition part as well later on.
Resolves: #125
Relates: coreos/fedora-coreos-tracker#1324