Packagesystem cleanup #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for cleaning this up and making it more generic to support non-rpm systems in a pluggable way.
There's no reason to have two separate functions here.
On general principle.
It doesn't make sense to hardcode the file list inside the query function; just have the caller pass it the files it needs. Now the packagesystem module is independent of the content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor rpm bits into packagesystem module
Prep for cleaning this up and making it more generic
to support non-rpm systems in a pluggable way.
De-duplicate package querying
There's no reason to have two separate functions here.
packagesystem: Add a unit test
On general principle.