Add get_efi_vendor method to both the bios and efi backends
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuijingHei
force-pushed
the
get-efi-vendor
branch
2 times, most recently
from
3936be9
to
cafe676
Compare
travier
reviewed
May 6, 2024
|
From a very quick look, this looks good. Maybe we should add a test for it to make sure we didn't miss something. |
HuijingHei
force-pushed
the
get-efi-vendor
branch
2 times, most recently
from
929d842
to
eae331f
Compare
See Colin's comment coreos#646 (comment)
HuijingHei
force-pushed
the
get-efi-vendor
branch
2 times, most recently
from
4e960f5
to
bc586db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
get_efi_vendormethod to both the bios and efi backends.See Colin's comment
#646 (comment)
ci: add
bootc install to-disktest in c9s-bootc-e2e