-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mount RHCOS LUKS #826
Mount RHCOS LUKS #826
Conversation
So I am still banging my head against this:
As best I can tell from reading the libguestfs source, that's saying that |
OK, built libguestfs from source and hacked in prefixing
Something about devmapper not being fully setup or something? |
bbdf569
to
533d4b4
Compare
533d4b4
to
53dedb9
Compare
So yeah, this took me a whole lot of time to debug because it was going OOM, but that was not at all obvious. See https://gitlab.com/cryptsetup/cryptsetup/issues/372 |
We need the internal libguestfs bits to work; at least `buildextend-installer` uses them. First, the main mount code needs to detect this by looking for the "luk_root"; if detected, use `luks-open` on it. The thing that took me *FOREVER* to debug is that we need more RAM for the libguestfs appliance, due to the new memory-hard argon2 KDF: https://gitlab.com/cryptsetup/cryptsetup/issues/372
53dedb9
to
dbf3e59
Compare
Lifting WIP on this, tested with both FCOS and RHCOS. |
Hm, actually this reveals that the memory we pass to qemu for I'm going to play with an explicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and very similar to what I fleshed out.
Merging, this is _very similar to #830. I'm merging and putting another PR for the other improvements. |
Add support for recognizing LUKS filesystem when setting up ignition. While not necessary for x86 because it uses fw_cfg, ppc64 and s390x use guestfish and need this change for kola tests to run. Introduced because of these changes: coreos/coreos-assembler#826
With the changes made recently: coreos/coreos-assembler#826, we need to add support for detecting LUKS root partitions which is really unnecessary as we are just injecting ignition in the boot partition. Based on suggestions by @cgwalters and @tuan-hoang1 in coreos#1118
We need the internal libguestfs bits to work; at least
buildextend-installer
uses them.