Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the logic to get right partition to increase the size #134

Closed
praveenkumar opened this issue Nov 28, 2019 · 1 comment
Closed

Update the logic to get right partition to increase the size #134

praveenkumar opened this issue Nov 28, 2019 · 1 comment

Comments

@praveenkumar
Copy link
Member

Since Red Hat CoreOS now moved with encryption so our virt-filesystem doesn't list those partitions, we need to make changes in that logic.
praveenkumar added a commit that referenced this issue Nov 28, 2019
@praveenkumar
Issue #134 Fix partition logic for encrypted partitions
f22ae91 
For an encrypted disk, virt-filesystem doesn't show all the partition
until specified. Also now there is no `root` label on partition so this logic
need to be changed.
```
$ virt-filesystems -a crc-ssnp7-base -l
Name       Type        VFS   Label       Size       Parent
/dev/sda1  filesystem  ext4  boot        402653184  -
/dev/sda2  filesystem  vfat  EFI-SYSTEM  133169152  -

$ virt-filesystems -a crc-ssnp7-base -l --partitions
Name       Type       MBR  Size         Parent
/dev/sda1  partition  -    402653184    /dev/sda
/dev/sda2  partition  -    133169152    /dev/sda
/dev/sda3  partition  -    1048576      /dev/sda
/dev/sda4  partition  -    16641932800  /dev/sda
```
praveenkumar added a commit that referenced this issue Nov 28, 2019
@praveenkumar
Issue #134 Fix partition logic for encrypted partitions
9506caa 
For an encrypted disk, virt-filesystem doesn't show all the partition
until specified.
```
$ virt-filesystems -a crc-ssnp7-base -l
Name       Type        VFS   Label       Size       Parent
/dev/sda1  filesystem  ext4  boot        402653184  -
/dev/sda2  filesystem  vfat  EFI-SYSTEM  133169152  -

$ virt-filesystems -a crc-ssnp7-base -l --partitions
Name       Type       MBR  Size         Parent
/dev/sda1  partition  -    402653184    /dev/sda
/dev/sda2  partition  -    133169152    /dev/sda
/dev/sda3  partition  -    1048576      /dev/sda
/dev/sda4  partition  -    16641932800  /dev/sda
```
praveenkumar added a commit that referenced this issue Nov 29, 2019
@praveenkumar
Issue #134 Fix partition logic for encrypted partitions
16dc7c7 
For an encrypted disk, virt-filesystem doesn't show all the partition
until specified.
```
$ virt-filesystems -a crc-ssnp7-base -l
Name       Type        VFS   Label       Size       Parent
/dev/sda1  filesystem  ext4  boot        402653184  -
/dev/sda2  filesystem  vfat  EFI-SYSTEM  133169152  -

$ virt-filesystems -a crc-ssnp7-base -l --partitions
Name       Type       MBR  Size         Parent
/dev/sda1  partition  -    402653184    /dev/sda
/dev/sda2  partition  -    133169152    /dev/sda
/dev/sda3  partition  -    1048576      /dev/sda
/dev/sda4  partition  -    16641932800  /dev/sda
```
@praveenkumar
Copy link
Member Author

resolved by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praveenkumar