This repository has been archived by the owner on May 7, 2021. It is now read-only.
Do not mount root parition for injecting ignition #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes made recently: coreos/coreos-assembler#826, we need to add support for detecting LUKS root partitions which is really unnecessary as we are just injecting ignition in the boot partition. Based on suggestions by @cgwalters and @tuan-hoang1 in coreos#1118
|
Yep, a lot simpler! LGTM, thanks! |
arithx
approved these changes
Nov 21, 2019
jlebon
approved these changes
Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes made recently: coreos/coreos-assembler#826, we need to add
support for detecting LUKS root partitions which is really unnecessary as we are just injecting ignition
in the boot partition.
Based on suggestions by @cgwalters and @tuan-hoang1 in #1118