-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provisioning: add instructions for OpenStack #202
Conversation
7209258
to
9843a68
Compare
|
||
== Prerequisites | ||
|
||
Before provisioning a FCOS machine, you must have an Ignition configuration file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: looks like we inconsistently use "a FCOS" and "an FCOS" throughout the docs. We should decide on one and clean up the docs in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cool with that. Want to open an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to an FCOS
by using a `clouds.yaml` file or via environment variables. If you're starting from scratch, this | ||
environment may need networks, ssh keypairs, security groups, etc.. set up. Please consult the | ||
https://docs.openstack.org/[OpenStack Documentation] to learn more. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention here what version of OpenStack the instructions below are tested against?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to new upload.
|
||
== Downloading an OpenStack Image | ||
|
||
Fedora CoreOS is designed to be updated automatically, with different schedules per stream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to https://docs.fedoraproject.org/en-US/fedora-coreos/update-streams/ here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a NOTE:
to mention it.
FCOS_VERSION='...' | ||
FILE=fedora-coreos-${FCOS_VERSION}-openstack.x86_64.qcow2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor/optional: meh... I'd just pick a sample version here and roll with that. I think it's understood that they'd sub in the filename they actually have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I copy and pasted this from another guide. I think all of them could probably use a single person going through and updating each of them so the language and common steps are a bit more consistent.
---- | ||
FCOS_VERSION='...' | ||
FILE=fedora-coreos-${FCOS_VERSION}-openstack.x86_64.qcow2 | ||
IMAGE=${FILE:0:-6} # pull off .qcow2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the canonical "shell way" to strip extensions is e.g. basename $FILE .qcow2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow. I've run basename $FILE
in the past many times, but never used it to pull off a suffix. TIL
I still think I'd prefer to keep it the way it is, without calling out to a binary to do the same thing.
---- | ||
|
||
Now you should be able to SSH into the instance using the IP address | ||
associated with the floating IP. If you didn't change the defaults the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
associated with the floating IP. If you didn't change the defaults the | |
associated with the floating IP. If you didn't change the defaults, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor: I noticed you 👍 this, but I don't see it in the latest push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I did indeed miss making that change. Should be done now!
9843a68
to
0df2e13
Compare
ok I think I addressed all comments. |
0df2e13
to
7e05807
Compare
No description provided.