Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioning: add instructions for OpenStack #202

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

dustymabe
Copy link
Member

No description provided.


== Prerequisites

Before provisioning a FCOS machine, you must have an Ignition configuration file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: looks like we inconsistently use "a FCOS" and "an FCOS" throughout the docs. We should decide on one and clean up the docs in a follow-up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with that. Want to open an issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to an FCOS

modules/ROOT/pages/provisioning-openstack.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/provisioning-openstack.adoc Outdated Show resolved Hide resolved
by using a `clouds.yaml` file or via environment variables. If you're starting from scratch, this
environment may need networks, ssh keypairs, security groups, etc.. set up. Please consult the
https://docs.openstack.org/[OpenStack Documentation] to learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention here what version of OpenStack the instructions below are tested against?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to new upload.


== Downloading an OpenStack Image

Fedora CoreOS is designed to be updated automatically, with different schedules per stream.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a NOTE: to mention it.

Comment on lines 40 to 41
FCOS_VERSION='...'
FILE=fedora-coreos-${FCOS_VERSION}-openstack.x86_64.qcow2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor/optional: meh... I'd just pick a sample version here and roll with that. I think it's understood that they'd sub in the filename they actually have.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I copy and pasted this from another guide. I think all of them could probably use a single person going through and updating each of them so the language and common steps are a bit more consistent.

----
FCOS_VERSION='...'
FILE=fedora-coreos-${FCOS_VERSION}-openstack.x86_64.qcow2
IMAGE=${FILE:0:-6} # pull off .qcow2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the canonical "shell way" to strip extensions is e.g. basename $FILE .qcow2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. I've run basename $FILE in the past many times, but never used it to pull off a suffix. TIL

I still think I'd prefer to keep it the way it is, without calling out to a binary to do the same thing.

modules/ROOT/pages/provisioning-openstack.adoc Outdated Show resolved Hide resolved
----

Now you should be able to SSH into the instance using the IP address
associated with the floating IP. If you didn't change the defaults the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor:

Suggested change
associated with the floating IP. If you didn't change the defaults the
associated with the floating IP. If you didn't change the defaults, the

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor: I noticed you 👍 this, but I don't see it in the latest push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did indeed miss making that change. Should be done now!

@dustymabe
Copy link
Member Author

ok I think I addressed all comments.

@dustymabe dustymabe merged commit 6df9ec4 into coreos:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants