This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
registry/rpc: use simpleBalancer instead of ClientConn.State() #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongsupark I'll have a look to the PRs and test them in my local cluster. |
dongsupark
force-pushed
the
dongsu/grpc-balancer
branch
from
c6db972
to
885b1e3
Compare
As ClientConn.State() of gRPC has disappeared, we need to avoid using ClientConn.State(). Instead we should make use of gRPC rebalancer mechanism, just like etcdv3 is doing. To do that, introduce simpleBalancer, as a minimum structure to be used for grpc.Balancer.
dongsupark
force-pushed
the
master
branch
3 times, most recently
from
20a3e96
to
3aaa1ab
Compare
|
As it's just a part of #1673, I'll close. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains only the relevant code of #1673, without vendor updates.
As
ClientConn.State()of gRPC has disappeared, we need to avoid usingClientConn.State(). Instead we should make use of gRPC rebalancer mechanism, just like etcdv3 is doing. To do that, introducesimpleBalancer, as a minimum structure to be used for grpc.Balancer./cc @hectorj2f