This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
[WIP] node approver #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rithujohn191 does this code structure work?? |
|
Lets start off by keeping this repo Bazel free so everyone can use it :) |
abhinavdahiya
force-pushed
the
node-csr-approver-init
branch
2 times, most recently
from
7562c2c
to
d9648db
Compare
abhinavdahiya
force-pushed
the
node-csr-approver-init
branch
from
d9648db
to
4d91941
Compare
|
Just a though: this is way to big to review. Can we talk about how to split it up and add little bits at a time? |
Closed
|
Closing in favor of #5 |
abhinavdahiya
pushed a commit
to abhinavdahiya/kubecsr
that referenced
this pull request
Jul 12, 2019
*: add OpenShift Dockerfiles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.