This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
kube-etcd-signer-server: add sign subcommand to sign CSRs from k8s API #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdahiya
force-pushed
the
standalone_sign
branch
from
3290be7
to
157ca69
Compare
Adds a sign subcommand that can be used by user to sign a CSR from k8s API using the internal signer. Example: ```console $ kube-etcd-signer-server --cacrt /opt/tectonic/tls/etcd-client-ca.crt --cakey /opt/tectonic/tls/etcd-client-ca.key sign --kubeconfig /etc/kubernetes/kubeconfig system:etcd-server:adahiya-master-0 ```
abhinavdahiya
force-pushed
the
standalone_sign
branch
from
157ca69
to
8e660eb
Compare
|
/cc @csrwng |
|
@abhinavdahiya this looks good to me. I assume this completes the story on signing etcd certs? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sign subcommand that can be used by user to sign a CSR from k8s API using
the internal signer.