Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

pkg/certagent: wait forever for CSR request to reply #27

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

hexfusion
Copy link
Member

@hexfusion hexfusion commented Apr 5, 2019

This PR reverts commit 7732233 and add will now wait for ever for CSR request to reply. Often times for various reasons the server is not up yet so we need to wait intead of exit 1 which results in crash loop.

@hexfusion
Copy link
Member Author

/cc @ericavonb @wking

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion changed the title Revert "*: add --max-retry flag to kube-client-agent" pkg/certagent: wait forever for CSR request to reply Apr 5, 2019
Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1e6478f looks good to me :).

@wking
Copy link
Contributor

wking commented Apr 5, 2019

CC @abhinavdahiya too

@abhinavdahiya
Copy link
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants