kola/qemu: Add a swtpm by default #1120
Conversation
The duplication in qemu code between cosa and kola needs to end - this is the start of moving some bits into kola. Eventually we'll have `cosa run` be a wrapper for something like `kola qemuexec`. This bit is the equivalent of coreos/coreos-assembler@55c9b65 We want to strongly emphasize use of TPM devices in CoreOS, so let's provision one by default. They can be used for disk encryption, secure secret storage, etc.
cgwalters
force-pushed
the
qemu-swtpm
branch
from
fce6e85
to
28d4a6b
Compare
|
We don't actually use |
|
Does anyone mind if I do a PR to make |
Is this considered a blocker? |
It's not, though I'd like at least @ajeddeloh or @arithx to have a look too. |
There was a problem hiding this comment.
Does anyone mind if I do a PR to make qemu-unpriv an alias for qemu?
Most of the features added in the qemu platform aren't being utilized for either *COS distribution set so I'd be okay making qemu-unpriv the default and providing the current qemu platform under a different handle.
No reason not to also do this for the qemu platform, right?
Is this considered a blocker?
I'm fine not having it in this PR
|
I don't have merge access btw (should I?) |
The duplication in qemu code between cosa and kola needs
to end - this is the start of moving some bits into kola.
Eventually we'll have
cosa runbe a wrapper for somethinglike
kola qemuexec.This bit is the equivalent of
coreos/coreos-assembler@55c9b65
We want to strongly emphasize use of TPM devices in CoreOS, so let's provision
one by default.
They can be used for disk encryption, secure secret storage, etc.