Add ExcludeArchitectures option for kola tests to exclude tests on certain arches #1131
Conversation
Prashanth684
force-pushed
the
mantle-arch-exclusion
branch
from
b65c71e
to
502947c
Compare
kola/tests/fips/fips.go
Outdated
| @@ -13,6 +13,9 @@ func init() { | |||
| Name: `fips.enable`, | |||
| Flags: []register.Flag{}, | |||
| Distros: []string{"rhcos"}, | |||
| // Dracut relies on BOOT_IMAGE parameter to find the kernel and the hmac. ON s390x, BOOT_IMAGE is not a path, | |||
| // but a number indicating the chosen record. This is discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1415032 | |||
There was a problem hiding this comment.
Hmm, this one looks fixable though. I.e. it's not inherent in the architecture, but just requires some dracut patches, right? Let's keep this as a blacklist instead (and file an issue to close that gap).
There was a problem hiding this comment.
I'm surprised this doesn't work. Doesn't RHEL support FIPS mode on s390x today?
Re. the path resolution thing, I added a comment on that RHBZ.
There was a problem hiding this comment.
ok...will do ..i put it in here because i was not sure about the timeline...but this can be fixed.
There was a problem hiding this comment.
the problem is two things: Firstly, the BOOT_IMAGE is not set on s390x on rhcos/fcos. I am not sure who sets it ? grub ? in that case it will not be set for s390x. Secondly, even if it is set - it is set to a number which represents the chosen record, so we have to translate that to the path.
…rtain arches Based on the comments in coreos/coreos-assembler#977 (comment), it makes sense to have an option to hardcode excluding certain tests which might never be supported for certain architectures. One good example is the rhcos.luks.tpm test which will probably never by supported on s390x. For powerpc , there is no concrete plans although there is talk of some effort soon. Disables luks test for s390x,ppc64le
Prashanth684
force-pushed
the
mantle-arch-exclusion
branch
from
502947c
to
7e40f94
Compare
Based on the comments in coreos/coreos-assembler#977 (comment), it makes sense to have an option to hardcode excluding certain tests which might never be supported for certain architectures. One good example is the rhcos.luks.tpm test which will probably never by supported on s390x. For powerpc , there is no concrete plans although there is talk of some effort soon.