Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

collect some journals #16

Merged
merged 1 commit into from
Apr 9, 2015
Merged

collect some journals #16

merged 1 commit into from
Apr 9, 2015

Conversation

mischief
Copy link
Contributor

@mischief mischief commented Apr 8, 2015

fixes #3

@brianredbeard
Copy link
Member

Just a nit, since this is the first commit talking about this can we get a little more detail in the commit log? Other than that, LGTM.

@mischief
collect some journals
5d56cb6 
we get a list of all units by calling systemd's ListUnits dbus api, and
iterate through them to find out which units were loaded from
/usr/lib/systemd/system, and then ask journalctl for their logs.

we collect just these journals so that hopefully we will not collect
logs from services created by users which may put private information
into the journal.

this method is not very good, but should suffice for now. in the future,
a whitelist of services should probably be used.
@mischief
Copy link
Contributor Author

mischief commented Apr 8, 2015

@brianredbeard PTAL

brianredbeard added a commit that referenced this pull request Apr 9, 2015
@brianredbeard
Merge pull request #16 from mischief/journal
3a39a93 
feature: add journal collection
@brianredbeard brianredbeard merged commit 3a39a93 into coreos:master Apr 9, 2015
@brianredbeard
Copy link
Member

LGTM. Merged.

@mischief mischief deleted the journal branch April 9, 2015 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect journal files from system
2 participants
@mischief @brianredbeard