DownloadUpdateRpmDiff leaves CachedUpdate property empty

[mvollmer]

** Host system details **

State: idle; auto updates disabled
Deployments:
● ostree://centos-atomic-continuous:centos-atomic-host/7/x86_64/devel/continuous
                   Version: 7.2017.1111 (2018-03-09 19:38:25)
                    Commit: 83d13b81707c0ce9ed2fbb532c53dd1bae5d7e938bfaaeba0246aa8e0998bba5

  ostree://centos-atomic-host:centos-atomic-host/7/x86_64/standard
                   Version: 7.1801 (2018-02-27 16:48:25)
                    Commit: 1a9591428c5cc77d1aa54158bf0144324ca2e5077659efe4d3dde8e2b5a0f654
              GPGSignature: Valid signature by 64E3E7558572B59A319452AAF17E745691BA8335

                            Valid signature by 64E3E7558572B59A319452AAF17E745691BA8335

(Hmm, check the second "Valid signature" output. It's in a funny place, no?)

** Expected vs actual behavior **

DownloadUpdateRpmDiff used to populate the CachedUpdate property, but that property stays empty now.

Actual, with rpm-ostree-2018.3.46-bb86912de9e750a57e3af9256940918ca7774744.5ffa5a9542a434458a377cf9c5ae3f6dbd5af4a9.el7.centos.x86_64

Signals during the method call:

DownloadUpdateRpmDiff SignatureProgress [[{"t":"(bbbbbsxxsssss)","v":[true,false,false,false,false,"95A8BA1754D0E95E2B3A98A7EE15015654780CBD",1520945935,0,"RSA","SHA1","Cockpit Tester","do-not-reply@cockpit-project.org","95A8BA1754D0E95E2B3A98A7EE15015654780CBD"]}],"be39f1a112ff7aadf734605f04fab416e2d237e7147a628a3d43ff84a79d1a9a"]
DownloadUpdateRpmDiff Message ["6 metadata, 10 content objects fetched; 9677 KiB transferred in 1 seconds"]
DownloadUpdateRpmDiff ProgressEnd []
DownloadUpdateRpmDiff Finished [true,""]

CachedUpdate property:

readonly a{sv} CachedUpdate = {};

Note that commit be39f1a112ff7aadf734605f04fab416e2d237e7147a628a3d43ff84a79d1a9a was mentioned in "SignatureProgress", but it doesn't appear in CachedUpdate.

Expected, with rpm-ostree-2018.3.2-88324984ab2ef81f9d44683485b760e7f2120c02.d146cef5e4512d1aa71f1fdd95d0e3faf6b354cb.el7.centos.x86_64

Signals during the method call:

DownloadUpdateRpmDiff SignatureProgress [[{"t":"(bbbbbsxxsssss)","v":[true,false,false,false,false,"95A8BA1754D0E95E2B3A98A7EE15015654780CBD",1520943894,0,"RSA","SHA1","Cockpit Tester","do-not-reply@cockpit-project.org","95A8BA1754D0E95E2B3A98A7EE15015654780CBD"]}],"4eef08ffe23de5cfcee1c913a4de2c4744494066ba7d1e24b214c76d4bfce8c8"]
DownloadUpdateRpmDiff Message ["6 metadata, 10 content objects fetched; 9666 KiB transferred in 0 seconds"]
DownloadUpdateRpmDiff ProgressEnd []
DownloadUpdateRpmDiff Finished [true,""]

CachedUpdate property:

readonly a{sv} CachedUpdate = {'osname': <'centos-atomic-host'>, 'timestamp': <uint64 1520943894>, 'origin': <'local:centos-atomic-host/7/x86_64/devel/continuous'>, 'checksum': <'4eef08ffe23de5cfcee1c913a4de2c4744494066ba7d1e24b214c76d4bfce8c8'>, 'gpg-enabled': <true>, 'version': <'cockpit-base.2'>, 'signatures': <[<(true, false, false, false, false, '95A8BA1754D0E95E2B3A98A7EE15015654780CBD', int64 1520943894, int64 0, 'RSA', 'SHA1', 'Cockpit Tester', 'do-not-reply@cockpit-project.org', '95A8BA1754D0E95E2B3A98A7EE15015654780CBD')>]>};

Here, commit 4eef08ffe23de5cfcee1c913a4de2c4744494066ba7d1e24b214c76d4bfce8c8 appears in CachedUpdate, as expected.

Steps to reproduce it

This is again from check-ostreein the Cockpit integration tests.