-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go and Rust client bindings #2389
Comments
On the Rust side we could also use it here https://github.com/ostreedev/ostree/blob/5551c54c6e6eba8145b95bd3b28223f1941a9e8d/tests/inst/src/rpmostree.rs#L16 |
That's the route we took with go-systemd and at least on the Go side it is probably a better idea. On the Rust side, Zincati has a bunch of CLI-parsing methods here, but that's probably good enough for now as there isn't yet a good non-blocking DBus library. |
This is intended to be published to https://crates.io/crates/rpmostree-client Part of coreos#2389 This directly imports the code from https://github.com/ostreedev/ostree/blob/5551c54c6e6eba8145b95bd3b28223f1941a9e8d/tests/inst/src/rpmostree.rs Once merged and released I'll try converting the ostree test suite over as well as Zincati. Internally add a testutils helper to validate it works.
This is intended to be published to https://crates.io/crates/rpmostree-client Part of coreos#2389 This directly imports the code from https://github.com/ostreedev/ostree/blob/5551c54c6e6eba8145b95bd3b28223f1941a9e8d/tests/inst/src/rpmostree.rs Once merged and released I'll try converting the ostree test suite over as well as Zincati. Internally add a testutils helper to validate it works.
This is intended to be published to https://crates.io/crates/rpmostree-client Part of coreos#2389 This directly imports the code from https://github.com/ostreedev/ostree/blob/5551c54c6e6eba8145b95bd3b28223f1941a9e8d/tests/inst/src/rpmostree.rs Once merged and released I'll try converting the ostree test suite over as well as Zincati. Internally add a testutils helper to validate it works.
This is intended to be published to https://crates.io/crates/rpmostree-client Part of #2389 This directly imports the code from https://github.com/ostreedev/ostree/blob/5551c54c6e6eba8145b95bd3b28223f1941a9e8d/tests/inst/src/rpmostree.rs Once merged and released I'll try converting the ostree test suite over as well as Zincati. Internally add a testutils helper to validate it works.
I've created https://github.com/cgwalters/rpmostree-client-go |
Motivated by openshift/machine-config-operator#2302
and the zincati bit in coreos/coreos-assembler#1964
Basically let's create e.g.
github.com/coreos/rpm-ostree-client-go
andgithub.com/coreos/rpm-ostree-client-rust
bindings that mostly have:status --json
into strongly typed structs (as both the MCD and Zincati do)rpm-ostree ...
with arguments but also kind of requires them to set theRPMOSTREE_CLIENT_ID
env var (maybe via aContext
struct or so?)Of course these bindings could directly invoke via DBus too but that greatly increases the scope.
The text was updated successfully, but these errors were encountered: