Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: verify that no regression on older builds after updating rpm-ostree #4776

Closed
HuijingHei opened this issue Jan 15, 2024 · 0 comments · Fixed by #4806
Closed

ci: verify that no regression on older builds after updating rpm-ostree #4776

HuijingHei opened this issue Jan 15, 2024 · 0 comments · Fixed by #4806
Assignees
Labels
jira for syncing to jira

Comments

@HuijingHei
Copy link
Member

HuijingHei commented Jan 15, 2024

Refer to @cgwalters 's suggestion coreos/fedora-coreos-config#2795 (comment),

It would be better to add such tests in CI like this:

  • start from the old version (e.g. boot fcos stable)
  • do the override remove, upgrade to a version with the new rpm-ostree
  • upgrade again to new target

More content from @jlebon :
Have a single test that

  • leverages every client-side layering feature (e.g. kernel override, initramfs args, initramfs-etc, layering, overrides, etc...)
  • verify that it can upgrade to the test deployment (composed with and containing the PR code)
  • then upgrade again to some new target
@HuijingHei HuijingHei self-assigned this Jan 15, 2024
@HuijingHei HuijingHei added the jira for syncing to jira label Jan 15, 2024
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides according to coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Jan 19, 2024
Test new rpm-ostree with kernel override, initramfs args,
initramfs-etc, layering, overrides.
See coreos#4776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira for syncing to jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant