Enable compilation with librhsm #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jlebon
reviewed
May 13, 2022
First, add a generic `--enable-featuresrs=$x` autoconf bit which just passes through to `cargo build --features $x` so we don't need to mirror all future options in autoconf. Use this to add `--enable-featuresrs=rhsm` which basically boils down to passing `-DENABLE_RHSM_SUPPORT=1` to the libdnf cmake bits. This is important for subscriptions on RHEL.
Do the same thing the libdnf spec is doing to enable the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable compilation with librhsm
First, add a generic
--enable-featuresrs=$xautoconf bit which just passesthrough to
cargo build --features $xso we don't need to mirror allfuture options in autoconf.
Use this to add
--enable-featuresrs=rhsmwhich basically boilsdown to passing
-DENABLE_RHSM_SUPPORT=1to the libdnf cmake bits.This is important for subscriptions on RHEL.
spec: Add bcond for rhsm mirroring libdnf
Do the same thing the libdnf spec is doing to enable the feature.