treefile: Return . instead of "" for parent directory
#4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the root cause of coreos#4029 Basically we were calling `set_repos_dir("")` on the libdnf side and it simply did not handle that, failing to open the directory. (Though I'm not saying "Closes" since we should still fix the file monitoring stuff) I don't yet know why this seemed to work in some cases but not others though.
travier
approved these changes
Jan 24, 2023
cgwalters
added a commit
to cgwalters/os
that referenced
this pull request
Jan 24, 2023
This is a workaround for coreos/rpm-ostree#4278
|
openshift/os#1115 works around this successfully |
jlebon
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the root cause of
#4029
Basically we were calling
set_repos_dir("")on the libdnf side and it simply did not handle that, failing to open the directory.(Though I'm not saying "Closes" since we should still fix the
file monitoring stuff)
I don't yet know why this seemed to work in some cases but not others though.