Add kola tests and fix Name & Summary search
#4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kola` tests added to test basic search functionality (name, summary, name & summary, and glob matches). Small fix for the duplicate removal feature. The `set` used to store existing query results needed to be passed as a pointer to the `query_results_to_builder` function. This allowed the data within the `set` to persist outside the function call. A large was change made to the `Name & Summary` search feature. Previously, the function would only return results that contained ALL search terms within BOTH the name and summary. With this commit, results in which search terms match EITHER the name or summary will be returned. This better matches `dnf`/`yum` CLI functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1877
New Implementations:
kolatests addedName & Summarysearch feature fixedAs stated in the commit message:
Previously, the
Name & Summarysearch function would only return results that contained ALL search terms within BOTH the name and summary. With this commit, results in which search terms match EITHER the name or summary will be returned. This better matchesdnf/yumCLI functionality.Old
Name & Summarysearch function:New
Name & Summarysearch function: