compose: change opt_usrlocal_overlays to be an enum #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cgwalters
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This will allow us to more cleanly warn in the future if composefs is not enabled in some situations.
cgwalters
force-pushed
the
composefs-bound-default
branch
from
3301f8d
to
28f3f45
Compare
|
OK, typed this out, it compiles but haven't run the tests yet. |
cgwalters
force-pushed
the
composefs-bound-default
branch
2 times, most recently
from
e0e3af9
to
13fa62a
Compare
xref ostreedev/ostree-rs-ext#607 We need to support having `/opt` and `/usr/local` be directly on the rootfs. Change the existing knob for this to be more configurable. The stateoverlay path is now an internal-only knob; we expect people to do that externally.
jlebon
force-pushed
the
composefs-bound-default
branch
from
13fa62a
to
42e0541
Compare
|
Thanks for the fixup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref ostreedev/ostree-rs-ext#607
We need to support having
/optand/usr/localbe directlyon the rootfs. Change the existing knob for this to be more
configurable. The stateoverlay path is now an internal-only
knob; we expect people to do that externally.