ci: run the improved-sanity-test #899
Conversation
I actually stopped using this a long time ago. Looking at it now, it doesn't make much sense in multi-host situations. Let's just nix it.
Start running the improved-sanity-test from atomic-host-tests to make sure the system works. This is an easy way to get PR-level comprehensive integration tests for free. But note that we *don't* mark it as required since the tests are not stored here and it can happen that they need to be adjusted for new rpm-ostree behaviours. In this way, this added check also allows us to give a heads-up that breaking changes are coming.
|
Pending on projectatomic/atomic-host-tests#216. |
|
Mmm...not opposed, but I still think the other way around would be more useful (a-h-t reusing existing tests), as that would have solved the problem we hit. a-h-t wouldn't have had to duplicate the status tests, and would transparently inherit any fixes we did, etc. |
|
The value I think running the i-s-t at the PR level is that you get coverage for a lot of other things that your PR could affect. To me, what makes it valuable isn't so much the rpm-ostree specific tests (because we already have a pretty good testsuite), but all the other tests. Actually, thinking more on this, maybe this makes more sense in ostree rather than rpm-ostree since the former has many more reverse deps and just higher potential for breaking platform changes. |
|
Where are we on this? Is it a WIP? Close? |
|
bot, retest this please |
|
I'd like to give it a chance and see how useful it is in practice. Then, we can reconsider down the road? |
|
bot, retest this please |
Start running the improved-sanity-test from atomic-host-tests to make sure the system works. This is an easy way to get PR-level comprehensive integration tests for free. But note that we *don't* mark it as required since the tests are not stored here and it can happen that they need to be adjusted for new rpm-ostree behaviours. In this way, this added check also allows us to give a heads-up that breaking changes are coming. Closes: #899 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
Start running the improved-sanity-test from atomic-host-tests to make
sure the system works. This is an easy way to get PR-level comprehensive
integration tests for free.
But note that we don't mark it as required since the tests are not
stored here and it can happen that they need to be adjusted for new
rpm-ostree behaviours. In this way, this added check also allows us to
give a heads-up that breaking changes are coming.