This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
cli/common: introduce a common config file #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, this is coming from #37 (comment). |
squeed
approved these changes
May 12, 2017
|
LGTM, sweet. |
This introduces a `torcx-config-v0` JSON input to specify common torcx configuration. This is mostly useful for torcx-generator, as it can't be passed custom command-line or environmental flags. The config file is located by default under `/etc/torcx/config.json` but can be moved somewhere else by specifying `torcx_config=` as a kernel boot option.
lucab
force-pushed
the
ups/config-from-file
branch
from
a8fe067
to
c21d8d3
Compare
|
Single line change to resolve a simple move conflict, I'm keeping previous LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
torcx-config-v0JSON input to specify commontorcx configuration. This is mostly useful for torcx-generator, as
it can't be passed custom command-line or environmental flags.
The config file is located by default under
/etc/torcx/config.jsonbut can be moved somewhere else by specifying
torcx_config=as akernel boot option.