This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
ftest/generator: test for missing next-profile #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm0-
approved these changes
Jun 16, 2017
ftests/generator_test.go
Outdated
| imgRef := profManifest.Value.Images[0].Reference | ||
| expName := "empty_vendor" | ||
| expRef := "com.coreos.cl" | ||
| if imgName != "empty_vendor" { |
There was a problem hiding this comment.
Is it intentional to define the expected value above and not use it?
ftests/generator_test.go
Outdated
| expName := "empty_vendor" | ||
| expRef := "com.coreos.cl" | ||
| if imgName != "empty_vendor" { | ||
| t.Errorf("Expected image name %q, got %q", expName, imgLen) |
There was a problem hiding this comment.
I think imgLen should be imgName here.
lucab
force-pushed
the
ups/ftest-generator-vendor
branch
from
886eb49
to
4663c02
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a positive ftest covering the issue fixed in #72.
/cc @squeed @dm0-