Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #94: Adds 'HAProxy Technologies' as a commercial WAF appliance vendor #96

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

NickMRamirez
Copy link

No description provided.

@dune73
Copy link
Member

dune73 commented Jun 15, 2023

Hey @NickMRamirez, thank you for the PR, happy to list HAProxy together with the other alternatives.

I'm not entirely happy with the wording, though. It reads too much like marketing blurb. I realize that the description of Kemp / Progress includes the word "popular", but I think this is as far as it should go. If your product is the fastest LB, then good for you, but CRS can not make that judgement and given this is our documentation it would appear as if we would make this judgement. I'm also not sure our audience needs to learn about HAProxy Technologies as the company behind HAProxy. I guess you get my idea here.

And sorry for being so blunt, but @RedXanadu who is working on the documentation a lot in his spare time is a Loadbalancer.org employee and I really like how he is not pushing his agenda into the documentation.

@NickMRamirez
Copy link
Author

Not a problem. I put our boilerplate marketing text in, but it makes sense now why that wouldn't be appropriate. How does this updated text look?

### HAProxy Technologies

HAProxy Technologies embeds ModSecurity v3 in three of its products via the Libmodsecurity module. 
ModSecurity is included with: HAProxy Enterprise, HAProxy ALOHA, and HAProxy Enterprise Kubernetes
Ingress Controller. 

To learn more, visit the [HAProxy WAF solution page on haproxy.com](https://www.haproxy.com/solutions/web-application-firewall).

@dune73
Copy link
Member

dune73 commented Jun 16, 2023

Thank you for your understanding @NickMRamirez.

This sounds good to me.

@RedXanadu: Anything to add? Otherwise feel free to merge.

@RedXanadu
Copy link
Member

Thank you both! This looks perfect @NickMRamirez, thanks for your work on this. Merging now!

@dune73 As we get more vendors and options appearing, we should agree on an ordering. Maybe alphabetical, or sponsors first and then the rest alphabetical. A conversation for another day 🙂

@RedXanadu RedXanadu merged commit 7274678 into coreruleset:main Jun 19, 2023
@dune73
Copy link
Member

dune73 commented Jun 19, 2023

Good thinking. I thought that would be a question sooner or later. But now much pressure from integrators to be listed so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants