Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #57

Merged
merged 7 commits into from
Nov 26, 2020
Merged

Improve testing #57

merged 7 commits into from
Nov 26, 2020

Conversation

fgsch
Copy link
Contributor

@fgsch fgsch commented Nov 26, 2020

See individual commits for details.

continue-on-error will not bubble up the error, so fail for now.
@fgsch fgsch requested a review from fzipi November 26, 2020 12:03
This is only needed in the python 2 case so we don't need to do anything
here.
There are various errors that require a newer version of pytest, which
is incompatible with python2. While we migrate away, limit these tests
to Python 3.9.
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@fgsch fgsch closed this Nov 26, 2020
@fgsch fgsch reopened this Nov 26, 2020
@fgsch fgsch merged commit c28e3ef into main Nov 26, 2020
@fgsch fgsch deleted the fgsch/improve-ci branch November 26, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants