Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MainObjectId Setter #2375

Closed
solverat opened this issue Sep 22, 2023 · 1 comment
Closed

MainObjectId Setter #2375

solverat opened this issue Sep 22, 2023 · 1 comment
Assignees
@dpfaffenbauer
Labels
bug
Milestone
3.1.2

Comments

@solverat
Copy link
Contributor

Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? no

In Version 2.x, the CartItemToSaleItemTransformer also stored the main object ID of a given variant.
This Method has been removed without any notes, which has caused us some serious problems.

However, I don't know if you want to re-add this feature via CartItemProcessor but there are several orphans (especially reports, which won't work without it):

https://github.com/search?q=repo%3Acoreshop%2FCoreShop%20mainobjectid&type=code
@dpfaffenbauer
Copy link
Member

we can for sure add it again in a Processor

@dpfaffenbauer dpfaffenbauer mentioned this issue Sep 27, 2023
Merged
@dpfaffenbauer dpfaffenbauer added this to the 3.1.2 milestone Sep 28, 2023
@dpfaffenbauer dpfaffenbauer self-assigned this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpfaffenbauer dpfaffenbauer

Labels
bug
Projects
None yet
Milestone
3.1.2
Development

No branches or pull requests
2 participants
@solverat @dpfaffenbauer