Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-tensor attributes of nn objects are not saved by SaveToNpz/LoadFromNpz #485

Closed
coreylowman opened this issue Feb 24, 2023 · 2 comments · Fixed by #799
Closed

Non-tensor attributes of nn objects are not saved by SaveToNpz/LoadFromNpz #485

coreylowman opened this issue Feb 24, 2023 · 2 comments · Fixed by #799
Labels
bug Something isn't working

Comments

@coreylowman
Copy link
Owner

This is currently affecting:

  • BatchNorm2D::epsilon
  • BatchNorm2D::momentum
  • Dropout::p
  • LayerNorm1D::epsilon
@coreylowman coreylowman added the bug Something isn't working label Feb 24, 2023
@TimerErTim
Copy link
Contributor

Would it be feasable to store those values as scalar tensor instead and let the RecursiveWalker handle the rest upon saving and loading?

@coreylowman
Copy link
Owner Author

Yeah good idea, very straightforward!

@TimerErTim TimerErTim mentioned this issue Feb 28, 2023
Closed
@Awpteamoose Awpteamoose mentioned this issue May 30, 2023
Open
@nkoppel nkoppel mentioned this issue Jun 28, 2023
Merged
nkoppel added a commit to nkoppel/dfdx that referenced this issue Jun 28, 2023
@nkoppel
add scalars to TensorCollection impls for examples listed in coreylow…
bf83966 
…man#485
coreylowman added a commit that referenced this issue Jul 10, 2023
@nkoppel @coreylowman
Add scalar support to TensorCollection (#799)
c161811 
* add infrastructure for hyperparameter support for TensorCollections; add Gradients::as_model

* run cargo fmt

* use 'scalar' instead of 'hyperparameter'; use NumCast instead of ToPrimitive

* run cargo fmt

* add scalars to TensorCollection impls for examples listed in #485

* run cargo fmt

* implement npz scalar serialization

* fix documentation; simplify tensor/numpy.rs

* add scalars to safetensor serialization

* small simplification

---------

Co-authored-by: Corey Lowman <clowman1993@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@coreylowman @TimerErTim