Simplify upscale cuda kernels #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkoppel for some reason this seems to resolve the bug? I have no idea why. On main I get an illegal memory address accessed. But not on this branch |
|
This seems to fix it on my end as well, though I am somewhat skeptical that it's not due to a different allocation pattern. |
coreylowman
commented
Apr 8, 2023
Comment on lines
+99
to
+102
| size_t y0 = min(static_cast<size_t>(h_scale * oh), op.h_in - 1); | ||
| size_t y1 = min(y0 + 1, op.h_in - 1); | ||
| size_t x0 = min(static_cast<size_t>(w_scale * ow), op.w_in - 1); | ||
| size_t x1 = min(x0 + 1, op.w_in - 1); |
There was a problem hiding this comment.
@nkoppel this was the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #677