Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements process-manifest command #23

Merged
merged 26 commits into from
Aug 26, 2022
Merged

Implements process-manifest command #23

merged 26 commits into from
Aug 26, 2022

Conversation

mscottford
Copy link
Member

Fixes #2.

@mscottford mscottford marked this pull request as ready for review August 24, 2022 14:59
@mscottford mscottford requested a review from klhoot August 24, 2022 14:59
mscottford and others added 20 commits August 24, 2022 10:59
@mscottford
Addresses linter errors
342651d
@mscottford
Marks string literals as frozen
f551081
@mscottford @klhoot
Reworks buffering logic
f325dba 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Experiment with moving println outside of runBlocking
897f23e 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Adds build step for installing cyclonedx-cli
7bacc7f 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Adjust length of stream buffer
de58f74 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Experiments with adding an intentionally non-blank line
41b1c8c 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Move constant definition outside of method call
dee3e5d 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Fixes issue with extra linebreaks appearing in output
8864342 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Adds debugging trace output
1a3c24f 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford @klhoot
Experiments with disabling sub-command output
7527bbd 
Co-Authored-By: Kimarie Hoot <52430349+klhoot@users.noreply.github.com>
@mscottford
Re-enables command output capture
1e19665
@mscottford
Changes the method for output capture console command output
fae1be3
@mscottford
Removes tracing output
4552d81
@mscottford
Use upterm action to get a shell session
a9c62e0
@mscottford
Changes the way process is invoked
7eb9cb6 
This switches to a single `runBlocking` statement instead of two different ones that there was before.
@mscottford
Adjusts aruba timeout
422a81d
@mscottford
Adds ./bin to path
0a944a3
@mscottford
Removes debugging session
5fe11e5
@mscottford
Removes extra spacing
9c11e24
klhoot
klhoot approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@klhoot klhoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/main/kotlin/com/corgibytes/freshli/agent/java/Main.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/corgibytes/freshli/agent/java/Main.kt Outdated Show resolved Hide resolved
@mscottford mscottford merged commit 3f02d33 into main Aug 26, 2022
@mscottford mscottford deleted the process-manifest branch August 26, 2022 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klhoot klhoot klhoot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement process-manifest command
2 participants
@mscottford @klhoot