Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cachecontrol headers issue: s3put doesn't support the nested "cachecontrol" element. #25

Closed
mikebrules opened this issue Jan 15, 2014 · 2 comments
Assignees

Comments

@mikebrules
Copy link

Hi, great task...

Following docs in README, woudl expect the following config to work:

<s3put endpoint="s3-eu-west-1.amazonaws.com" 
        key="${s3.access.key}" 
        secret="${s3.secret.key}" 
        bucket="${AWS_BUCKET}" 
        dest=""
        cachecontrol="max-age=60">
                        <cachecontrol extension=".js" maxage="86400"/>
                        <fileset dir="${dir.deploy}" includes="**/*" />
</s3put>

but getting...
s3put doesn't support the nested "cachecontrol" element.

Am I misusing?

Thanks

@ghost ghost assigned wdalmut Jan 15, 2014
@mikebrules
Copy link
Author

ahhh, this is a straight docs issue. Example file (example_build) has correct usage

<cachecontrolmapping extension=".html" cacheControl="max-age=60"/>

rather than

<cachecontrol extension=".html" cacheControl="max-age=60"/>

as README states....

Works great!

@wdalmut
Copy link
Member

wdalmut commented Jan 15, 2014

Thank you so much.

I'll update the README.md

@wdalmut wdalmut closed this as completed Jan 15, 2014
wdalmut added a commit that referenced this issue Jan 15, 2014
The cache control mapping examples are wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants