Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handling #13

Closed
JakeStanger opened this issue Nov 27, 2022 · 0 comments · Fixed by #16
Closed

Improved error handling #13

JakeStanger opened this issue Nov 27, 2022 · 0 comments · Fixed by #16
Labels
enhancement New feature or request

Comments

@JakeStanger
Copy link
Collaborator

The error code is a little messy at the moment, and the library makes heavy use of unwrap. Error code should be refactored and the parser/deserializer should not panic anywhere.
@JakeStanger JakeStanger added the enhancement New feature or request label Nov 27, 2022
@JakeStanger JakeStanger mentioned this issue May 24, 2023
Merged
JakeStanger added a commit that referenced this issue May 24, 2023
@JakeStanger
refactor: improve error handling and code quality
ab1af29 
Replaces any panics with proper error handling.

Removes all unwraps, replacing them with either proper error handling or
`expect` calls where appropriate.

Introduces `thiserror` to reduce error boilerplate, along with some
general improvements to error code.

Fixes several pedantic clippy warnings to improve code quality.

Updates several related dependencies.

Resolves #13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: improve error handling and code quality corn-config/corn
1 participant
@JakeStanger