Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show partial results when fetching of api resources fails #44

Merged
merged 3 commits into from
Jan 10, 2020

Conversation

corneliusweig
Copy link
Owner

Fixes #41

Cornelius Weig added 3 commits January 10, 2020 11:55
This new flag controls whether to fail with an error or continue with a
warning, when fetching the list of api resources fails.
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #44 into master will decrease coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   41.88%   41.81%   -0.07%     
==========================================
  Files           9        9              
  Lines         382      385       +3     
==========================================
+ Hits          160      161       +1     
- Misses        200      202       +2     
  Partials       22       22
Impacted Files Coverage Δ
internal/options/options.go 19.04% <ø> (ø) ⬆️
internal/client/client.go 22.79% <0%> (-0.35%) ⬇️
cmd/root.go 68.88% <100%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa7944...30c7f62. Read the comment docs.

@corneliusweig corneliusweig merged commit bce10e5 into master Jan 10, 2020
@corneliusweig corneliusweig deleted the w/partial-results branch January 10, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to skip failed GETs
2 participants